Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: cut v3.0.0 beta release #169

Closed
wants to merge 2 commits into from

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Feb 24, 2021

What type of PR is this?
/kind documentation

What this PR does / why we need it:
doc: cut v3.0.0 beta release

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

git checkout -b cut-v3.0.0
vi README.md
cd charts/
sed -i 's/v2.0.0/v3.0.0/g' README.md
cp latest/ v3.0.0 -r
cd v3.0.0/
grep latest ./* -R
sed -i 's/latest/v3.0.0/g' ./csi-driver-nfs/*.yaml
helm package csi-driver-nfs
git add csi-driver-nfs-v3.0.0.tgz
cd ../../
helm repo index charts --url=https://raw.githubusercontent.com/kubernetes-csi/csi-driver-nfs/master/charts
cd ./deploy/
mkdir v3.0.0
cp *.yaml v3.0.0/
cd v3.0.0/
grep latest ./* -R
sed -i 's/:latest/:v3.0.0/g' *.yaml
cd ..
grep latest ./* -R
sed -i 's/:latest/:v3.0.0/g' *.yaml
cd ../docs/
cp install-csi-driver-master.md install-csi-driver-v3.0.0.md
grep master install-csi-driver-v3.0.0.md
sed -i 's/master/v3.0.0/g' install-csi-driver-v3.0.0.md
cd ..
vi docs/install-nfs-csi-driver.md
git add charts/ deploy/ docs/
$git_commit
# second commit to revert back to latest version
cd deploy
sed -i 's/:v3.0.0/:latest/g' *.yaml
$git_commit

Does this PR introduce a user-facing change?:

doc: cut v3.0.0 beta release

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 24, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 596184505

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.47%

Totals Coverage Status
Change from base Build 591788102: 0.0%
Covered Lines: 548
Relevant Lines: 681

💛 - Coveralls

This is a repository for [NFS](https://en.wikipedia.org/wiki/Network_File_System) [CSI](https://kubernetes-csi.github.io/docs/) Driver.
Currently it implements bare minimum of the [CSI spec](https://github.com/container-storage-interface/spec) and is in the alpha state
of the development.
This is a repository for [NFS](https://en.wikipedia.org/wiki/Network_File_System) [CSI](https://kubernetes-csi.github.io/docs/) Driver, csi plugin name: `blob.csi.azure.com`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the azure blob reference.

memory: 20Mi
- name: node-driver-registrar
image: "{{ .Values.image.nodeDriverRegistrar.repository }}:{{ .Values.image.nodeDriverRegistrar.tag }}"
lifecycle:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest node-driver-registrar is distroless, so this prestop hook doesn't do anything. The latest version does have a sigterm handler to cleanup the registration socket.

charts/v3.0.0/csi-driver-nfs/values.yaml Show resolved Hide resolved
@@ -3,20 +3,29 @@ entries:
csi-driver-nfs:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update https://github.com/kubernetes-csi/csi-driver-nfs/tree/master/deploy? Seems like having 2 different copies of the spec will lead to confusion.

@jsafrane
Copy link
Contributor

@andyzhangx @msau42 do you plan to continue with the release? There are too many changes in master since v2.0.
cc @mdbooth

@andyzhangx
Copy link
Member Author

@andyzhangx @msau42 do you plan to continue with the release? There are too many changes in master since v2.0.
cc @mdbooth

@jsafrane sure, I will update this PR later this week.

@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants